Ticket #36 (closed defect: fixed)
Correctly lazify 'non-English' characters
| Reported by: | stuarth | Owned by: | stuarth |
|---|---|---|---|
| Priority: | major | Milestone: | 2.2.2 |
| Component: | Plugin | Version: | 2.2 |
| Keywords: | Cc: | b@… |
Description
A problem with non-English characters reported by Kim B. Heino:
While you're at it, how about supporting non-english characters too? For example, if I want to search for "Jättiläinen", now I have to search for "ttil".
I tried to modify tr in lazyEncode, but that didn't help. I hate perl... Simply encoding "äàáåâ" to "a" (and similar to other vowels) would be enough for most cases.
Change History
comment:2 Changed 5 years ago by stuarth
I've a beta release that appears to address this, which Kim will test: source:tags/2.2.2b1
comment:3 Changed 5 years ago by stuarth
- Status changed from new to assigned
An update from Kim:
Artist/Album/Song? LazySearch is working fine now, but Keyword isn't. If I enter the keyword search and press 2, the display shows "2". If I press 2 again, display shows "2,2" (again 2 -> "2,2,2"). Of course it doesn't find anything...
I used sql to force re-lazification. I'm doing full clear'n'rescan now to test again...
Yes, same problem.
I noticed something else too:
When doing Song search, the top line shows 'Songs matching "234"', but when doing Keyword, it shows 'Artists matching "2,3,4"'.
SlimServer SVN revision 9631 from trunk.
I've checked and I get the same behaviour here - I've definitely broken something as that was working very recently. It shouldn't be too hard to track down. The database lazification and main search does now seem to be working properly, though (the "2,2,2,2" problem concerns how the input is interpreted, not how the database contents is structured).
comment:4 Changed 5 years ago by stuarth
This has been resolved in r178 (note that the ZIP file in that revision hasn't yet been updated - you need to look at LazySearch.pm).
I'll wait for conformation from Kim before closing this completely.
comment:5 Changed 5 years ago by stuarth
- Status changed from assigned to closed
- Resolution set to fixed
From Kim:
I have good news! Non-English chars and keyword search are working fine now. You can close #36.
Translation was also merged fine.
On that basis I'll mark it as resolved. It'll appear in an official version when I release 2.2.2.
Thanks for testing it, Kim, and for providing the test data so I could reproduce things at home.
Kim, to help me out I wonder whether it would be possible for you to get me a dump of your MySQL database (I'm assuming it's MySQL as you're using 6.5/7.0)?
Either a real dump (ie the SQL output), or else the actual database files themselves would probably do, and they'd of course benefit from ZIPping or similar.
Would that be possible? A service such as http://www.transferbigfiles.com would be preferable to attaching a large file to this ticket.
If you don't know how to do that then let me know what platform you're on (Windows/Linux? etc) and I can probably help out.